search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
100 stars 24 forks source link

VerifyConnectivity not catching unconnected port #449

Open David-Durst opened 6 years ago

David-Durst commented 6 years ago

commonlib's serializer has a count port (https://github.com/David-Durst/coreir/blob/aetherlingMultipleParallelism/src/libs/commonlib.cpp#L1435)

I use serializer in my streamify (https://github.com/David-Durst/coreir/blob/aetherlingMultipleParallelism/src/libs/aetherlinglib/aeStreamifyArrayify.h#L56) but I never connect the count port to anything.

My streamify is used in a test that runs the verifyconnectivity pass (https://github.com/David-Durst/coreir/blob/aetherlingMultipleParallelism/tests/simulator/aetherlingHelpersSim.cpp#L134).

Is this a bug or am I missing something?

rdaly525 commented 6 years ago

It looks like you are running verifyconnectivity-onlyinputs. count is an output port. So this is completely valid. If you want to verify the connectivity of both inputs and outputs, use verifyconnectivity

David-Durst commented 6 years ago

I also use verifyconnectivity as the second to last pass. Is the flatten removing the unconnected stuff before I get to it?

rdaly525 commented 6 years ago

@David-Durst, was this resolved?