search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
100 stars 24 forks source link

added clang-format #861

Closed rdaly525 closed 4 years ago

rdaly525 commented 4 years ago

This is a start for the repo cleanup effort. Eventually I would like to force all C++ files to adhere to this.

leonardt commented 4 years ago

I'm not too picky on style specifics as long as it's consistent (and automated). Perhaps we can just this PR to do a big run over the code base to clang-format everything in one go?

rdaly525 commented 4 years ago

I'm not too picky on style specifics as long as it's consistent (and automated). Perhaps we can just this PR to do a big run over the code base to clang-format everything in one go?

Totally agree. Just wanted to get both of you on board with the .clang-format file before doing it.

rdaly525 commented 4 years ago

@rsetaluri I would need to test these out, but as long as at minimum it does what I have in my clang-format, I am amenable.

rdaly525 commented 4 years ago

https://reviews.llvm.org/D33029 I would also love to add this feature but it is unfortunately not merged yet :(

rsetaluri commented 4 years ago

@rdaly525 compare to #869

rsetaluri commented 4 years ago

Solved by #879