search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
101 stars 24 forks source link

Expose disable width cast option in binary #907

Closed leonardt closed 4 years ago

leonardt commented 4 years ago

For https://github.com/phanrahan/magma/issues/708

leonardt commented 4 years ago

Bump, this is needed by https://github.com/phanrahan/magma/pull/741

leonardt commented 4 years ago

Bump, needed for https://github.com/phanrahan/magma/pull/741

leonardt commented 4 years ago

Agreed, a simpler temporary solution would be to just prefix them with "v" (e.g. -vw). I think the issue is that we need to passthrough the arguments to the verilog pass, but that pass is called implicitly by the choice of the ".v" output. Another option is to provide some argument like "output_pass_args" that will forward arguments to the final pass.

rdaly525 commented 4 years ago

I like the "output_pass_args" route except I would want to call it something like "serialization_args" or even "codegen_args"