search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
101 stars 24 forks source link

Allow test_isolate to run without install #927

Closed leonardt closed 4 years ago

leonardt commented 4 years ago

This updates the commonlib loading logic so that it works without having corier installed into a system path (the current logic assumes it's available somewhere, but sometimes when you're developing locally and you don't have a copy installed into the system)

rsetaluri commented 4 years ago

Does this work if the commonlib.so is dynamically linked? consulting @rdaly525 for any weirdnesses here...

leonardt commented 4 years ago

Yes, this was how libraries were designed to be loaded (see https://github.com/rdaly525/coreir/blob/master/doc/LibraryGuide.md#libraries), it's also how the other tests all load the libraries (https://github.com/rdaly525/coreir/blob/master/tests/gtest/test_verilog.cpp#L166-L168)