rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
101 stars 24 forks source link

Pin verilogAST version to a specific directory #934

Closed leonardt closed 4 years ago

leonardt commented 4 years ago

While we normally keep coreir/verilogAST-cpp master branches in sync, this presents a problem with the https://github.com/StanfordAHA/aha flow. Basically, coreir master may be updated, but other PRs into the main branch of the aha flow will use an older version of coreir (before the coreir bump PR has been merged), which will pull verilogAST-cpp master and may cause a build failure (since it's using an old commit of coreir not up to date with verilogAST-cpp master). This avoids the issue by pinning the verilgoAST-cpp commit in the Cmake dependency logic