search

rdaly525 / coreir

BSD 3-Clause "New" or "Revised" License
100 stars 24 forks source link

Add suport for .sv extension #978

Closed leonardt closed 3 years ago

leonardt commented 3 years ago

Needed for https://github.com/phanrahan/magma/issues/880

Allows the user to choose .sv as an output. In the future, we should consider forcing the disable-ndarray option when .v is used (i.e. choosing .sv enables this feature since it should be compatible with tools that support .sv). However, for backwards compatability, I think we should leave the behavior as is (or else various downstream users will have different code generated by default since everyone is using .v right now but some are expected the ndarray feature enabled for .v).

leonardt commented 3 years ago

When we update magma to choose .sv versus .v depending on whether ndarray is enabled, I think we can make the change here to disable ndarray for .v

rdaly525 commented 3 years ago

Looks like there is some call that is missing the outExt parameter causing the failing CI. Alternatively you could have a default value.