rdatatable-community / The-Raft

A blog for the data.table community.
https://rdatatable-community.github.io/The-Raft/
3 stars 10 forks source link

Submitting collapse for the Seal of Approval. #46

Closed SebKrantz closed 2 months ago

SebKrantz commented 2 months ago

Seal of Approval Checklist

OR

Categories:

The relationship between this package and data.table is best described as:

Message for maintainers

If your package is accepted by The Raft, it will be passed along to the data.table developer team for final approval.

Would you like to pass along any information or messages directly to the team along with your blog post?

(Belatedly) responding to my discussion with Toby.

Dev-do not edit

Review request @kbodwin

kbodwin commented 2 months ago

Thank you for this, it looks great!

I'm pulling into dev branch for now, once it is approved by the data.table team (https://github.com/Rdatatable/data.table/pull/6529) we'll publish. Feel free to make changes via comment or PR in the meantime. :)

SebKrantz commented 2 months ago

Thanks @kbodwin! I've fixed the typos here, thanks @Anirban166! And PS @kbodwin, the 'Seal of Approval Checklist' template has your old GitHub handle (@kellybodwin) in it, which will not link you (I edited it in my PRs).

SebKrantz commented 2 months ago

Hi @tdhock, thanks. I have fixed the typos, including 'Its' here: https://github.com/rdatatable-community/The-Raft/pull/47. Since this PR was closed early, it could not be updated.