search

rdatsci / rtcl

R tools for the command line
65 stars 3 forks source link

it is really hard to install rt #15

Closed berndbischl closed 8 years ago

berndbischl commented 8 years ago

First, I got a stringr error:

'regex' is not an exported object from 'namespace:stringr'

Forcing me to update this. So at least the version dep in not correctly set in rt:DESCRIPTION.

After a stringr update I now get this:

di68kay@lxa191:~/cos/BatchJobs> rmake Error: unused argument (create = FALSE)

Which does not even tell me the function/package it relates to. I had this before, now I have to search again which package I have to update :(

berndbischl commented 8 years ago

I guess it is devtools, where the version dep is again also wrong

mllg commented 8 years ago

You have to debug it yourself, this is not reproducible.

berndbischl commented 8 years ago

I already told you the answer, depend on the recent versions?

and put it on cran

berndbischl commented 8 years ago

i also told you which stuff in the signatures you need, if you want to depend on older versions....

berndbischl commented 8 years ago

and guess how i found those answers.... by debugging it myself

mllg commented 8 years ago

Send a PR then.

berndbischl commented 8 years ago

i have depended on the newest devtools version, which implies R 3.0.2

do you use stringr internally? I guess you cannot, as only stringi is in rt NS?

so I might guess that the stringr problem is actually due to devtools as well

why not push to cran?

mllg commented 8 years ago

do you use stringr internally? I guess you cannot, as only stringi is in rt NS?

Exactly. I only use stringi.

so I might guess that the stringr problem is actually due to devtools as well

So, still broken?

why not push to cran?

I will, as soon as I think that rt is mature enough. But this would not fix this issue, you obviously got rt installed, right?

berndbischl commented 8 years ago

So, still broken?

I dont get your point? Also, I cannot check this, I would need to go back in installed versions of dependencies on my system.

you obviously got rt installed, right?

I did yes. Most other people would have not. It also cost me more lifetime than it should.

Also:

if we use it all the time why is it not mature enough?

berndbischl commented 8 years ago

The more underlying question is also, how can one check if the version requirements one put into DESCRIPTION are actually correct.

I guess there is no doable approach though. This would require downloading outdated versions from CRAN (which cannot be automated).

My final suggestions here:

a) close this issue b) upload to CRAN