search

rdatsci / rtcl

R tools for the command line
65 stars 3 forks source link

Again, it is not OK that the dir where the check logs are stored is removed after rcheck #3

Closed berndbischl closed 8 years ago

berndbischl commented 9 years ago

I need to read them in cases of error

jakobbossek commented 9 years ago

+1

mllg commented 9 years ago

Does the argument --nocleanup work for you guys?

rcheck --help

berndbischl commented 9 years ago

No, because it is not the default.

berndbischl commented 9 years ago

I can see why one does not want these files filling up the project dir, but why not put them in the temp, and leave them there, and print out the path to the logfiles?

berndbischl commented 9 years ago

(Which is exaxtly what happens now, minus the "leaving the directory, instead of removing it")

mllg commented 9 years ago

The temp directory should not be removed with --nocleanup?

berndbischl commented 9 years ago

You are not answering to what I said?

mllg commented 9 years ago

The temp directory is already persistent if you pass the argument.

If you do not like the default, you can always toggle it by defining a bash alias.

Reason to not make nocleanup the default: /tmp is nowadays usually mounted as tmpfs. If you do not clean up, you might end up using a considerable amount of memory on systems with longer uptimes (e.g., compute servers).

berndbischl commented 9 years ago

Ok, thanks for the info in the last reply at the end.

What happens is that people get confused here:

Status: 1 ERROR
See
  ‘/tmp/RtmpiAht3F/BBmisc.Rcheck/00check.log’
for details.

And then that dir does not exist. I would at least point them to the "nocleanup" option in a helpful info message.

berndbischl commented 9 years ago

Preferrably at the end of the output.

surmann commented 8 years ago

An info in case of the default would be fine.