search

rdatsci / rtcl

R tools for the command line
65 stars 3 forks source link

rspell update to hunspell #52

Closed surmann closed 4 years ago

surmann commented 5 years ago

I like the more compact output of hunspell. Should we update rspell to hunspell?

surmann commented 4 years ago

In the meantime I found the package spelling: https://github.com/ropensci/spelling

What do you think? It checks the whole package, also as unit tests, and runs smoothly under windows.

If you have no concerns, I would like to change the spell check to spelling::spell_check_package().

mllg commented 4 years ago

Ok for me.

jakob-r commented 4 years ago

@surmann Do you want to do the PR?

surmann commented 4 years ago

Yes. I just want to know if you have any thoughts on this or if it is ok for you.

surmann commented 4 years ago

@jakob-r Do you have any ideas why Appveyor fails on this commit?

jakob-r commented 4 years ago

Sorry. I don't have a clue. I guess it runs through on Windows locally?

surmann commented 4 years ago

Yes. I tested and checked it on my machine. Should we merge the commit?

jakob-r commented 4 years ago

done :)