rdavydov / Twitch-Channel-Points-Miner-v2

A simple script that will watch a stream for you and earn the channel points.

GNU General Public License v3.0

1.21k stars 352 forks source link

Fix regex for settings when getting spade url #489

Closed Rakambda closed 5 months ago

Rakambda commented 5 months ago

Description

PR based on the fix I did for my repo https://github.com/RakambdaOrg/ChannelPointsMiner/pull/750 Seems to have fixed the issue. For some channels the settings url is not hosted on the same host.

Fixes #487 (issue)

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Didn't test it for this repo, I'll let people see if this works here too.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (README.md)
[x] My changes generate no new warnings
[ ] Any dependent changes have been updated in requirements.txt

xTunio commented 5 months ago

I've been running v2-1.9.4 with patch from PR for 2 hours straight, seems to work fine. LGTM