search

rdawg-pidinst / schema

RDA WG PIDINST Metadata Schema
Other
21 stars 4 forks source link

manufacturerIdentifier #13

Closed huberrob closed 3 years ago

huberrob commented 5 years ago

The term manufacturerIdentifier could be misunderstood it has to be clarified what it means:

1) The identifier given to and instrument by its manufacturer or 2) The identifier of the manufacturer itself.

RKrahl commented 5 years ago

It is intended to mean an identifier of the manufacturer itself. The inclusion of this subproperty has been proposed by me in #3. What would you suggest to avoid misunderstandings?

markusstocker commented 5 years ago

I agree it is ambiguous. The definition "Persistent identifier of the manufacturer" is clear, I think, but the question is whether this should be made more explicit in the attribute name, e.g. identifierOfManufacturer (though it isn't as pretty).

RKrahl commented 5 years ago

Well, if “Persistent identifier of the manufacturer” is clear, that is the current definition that we have in the schema. So either we assume that people take notice of the definition, then there should be no problem here, or we assume they don't and try to squeeze the definition into the property names. That would become really cumbersome for many properties. And then, if we assume that people do not take notice of the definition in the first place, why should we assume that they try to observe property names?

huberrob commented 5 years ago

OK I see .. as a subproperty it is clear what is meant with it .. but the definition should be updated to avoid ambiguities.

RKrahl commented 5 years ago

The current definition is “Persistent identifier of the manufacturer”. What other definition do you suggest?

huberrob commented 5 years ago

Maybe: 'Persistent institution identifier which is used to identify the manufacturer of the instrument or sensor, this can be an ORCID, ISNI or similar'

On Wed, Feb 27, 2019 at 1:07 PM Rolf Krahl notifications@github.com wrote:

The current definition is “Persistent identifier of the manufacturer”. What other definition do you suggest?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rdawg-pidinst/schema/issues/13#issuecomment-467837956, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVux9-_4CGMWqhohvXd5t5NdDRwfkZ_ks5vRnUAgaJpZM4bJ-ZE .

-- Dr. Robert Huber,

PANGAEA - www.pangaea.de

MARUM - Center for Marine Environmental Sciences University Bremen Leobener Strasse POB 330 440 28359 Bremen Phone ++49 421 218-65593, Fax ++49 421 218-65505 e-mail rhuber@uni-bremen.de

RKrahl commented 5 years ago

Some minor nitpicking:

In short, I'd suggest: “Persistent identifier which is used to identify the manufacturer of the instrument.” Ok?

markusstocker commented 5 years ago

A couple of (shorter) alternatives:

Persistent identifier used to identify the manufacturer of the instrument

or

Persistent identifier that identifies the manufacturer of the instrument

or

Persistent identifier of the manufacturer of the instrument

RKrahl commented 5 years ago

The third suggestion is (almost) what we have now: “Persistent identifier of the manufacturer”.

louatbodc commented 5 years ago

Excellent. Happy to close this

louatbodc commented 5 years ago

Whoops commented on the wrong issue! This is not the one I want to close

huberrob commented 5 years ago

I would vote for : Persistent identifier used to identify the manufacturer of the instrument

RKrahl commented 3 years ago

Note that manufacturerIdentifier is a subproperty of Manufacturer. I suggest that “of the instrument” is redundant with the overall context of this schema, but also with the description of Manufacturer: “The instrument's manufacturer(s) or developer. […]”. Therefore, I'd propose: “Persistent identifier used to identify the manufacturer”