rdbende / chlorophyll

A Tkinter widget that fills your code with color
https://pypi.org/project/chlorophyll/
MIT License
43 stars 9 forks source link

Add `toml` and `pygments` to `requirements.txt` #44

Closed littlewhitecloud closed 1 year ago

littlewhitecloud commented 1 year ago

image image Really a good project, but it seems that the requirements.txt lost toml. @rdbende Can you check it out?

rdbende commented 1 year ago

I'm wondering though, whether we need requiremente.txt at all.

littlewhitecloud commented 1 year ago

LOL I forget pygments too.


I'm wondering though, whether we need requirements.txt at all.

requirements.txt is in need, for someone who wants to make a contribution. And then can do

pip install -r requirements.txt

To quick install the require libs in need.

rdbende commented 1 year ago

For development I recommend this

python3 -m venv env
source env/bin/activate
pip install -e .

(it's a bit different on Windows)

This will install chlorophyll as editable using the setup.py, so there's no need for the requirements.txt

littlewhitecloud commented 1 year ago

That's fine, but I prefer to execute pip install -r requirements.txt and edit on the current path. (Maybe someone who like me never hear about pip install -e . will use pip install -r requirements.txt.)

littlewhitecloud commented 1 year ago

So we don't need requirements.txt now?

Moosems commented 1 year ago

I honestly do it the same way as white cloud. Not my repo though :).

littlewhitecloud commented 1 year ago

I honestly do it the same way as white cloud. Not my repo though :).

LOL I was afraid only I didn’t know the command.

littlewhitecloud commented 1 year ago

@rdbende Whether to delete or not, it's up to you to decide

rdbende commented 1 year ago

I honestly do it the same way as white cloud. Not my repo though :).

But in a venv?

rdbende commented 1 year ago

So we don't need requirements.txt now?

Let's keep it