search

rdefeo / quac

Flipperzero app that acts as a QUick ACtion remote control for multiple signal types
https://lab.flipper.net/apps/quac
38 stars 4 forks source link

Different buttons .sub files issue: only first .sub file executed remains functional across different buttons #3

Open gekich opened 5 months ago

gekich commented 5 months ago

Hey, first of all, thanks for creating such a useful application, i really love the idea.

I have an issue with the different buttons of the same FOB files.

Steps to reproduce

  1. Locate different buttons subghz files, for example 00_BUTTON_4 and 01_BUTTON_6 at quac/00_TEST. Protocol is KeeLoq 64 bit Screenshot-20240324-163800

Emulation of those files using Sub-GHz application:

Button 4 Screenshot-20240324-163815

Button 6 Screenshot-20240324-163826

  1. Open the Quac application, open the TEST folder, press for example 4 times on BUTTON 4, than once on BUTTON 6

  2. Emulate 00_BUTTON_4 and 01_BUTTON_6 again, both buttons are "Btn: 4" Emulation screenshots:

Button 4 Screenshot-20240324-163948

Button 6 Screenshot-20240324-163957

As a result button 6 is not working now.

I've noticed the issue whilst using the application: only the first .sub file I've executed remained working between different buttons.

rdefeo commented 5 months ago

Hi @gekich ! Thanks for reporting - which version of the app are you using?

gekich commented 5 months ago

Hi @gekich ! Thanks for reporting - which version of the app are you using?

I was using quac v0.4 along with RogueMaster FW version RM0321-1526-0.99.2-e78d0d7

rdefeo commented 5 months ago

Think I might have been handling RAW files incorrectly - found a possible bug. Will continue testing this evening and hope to push new changes this weekend

rdefeo commented 5 months ago

I may have spoken too soon - still debugging. If possible can you try a few things?

Since I don't have physical devices that accept all forms of sub-ghz file types, it's a bit tricky to know if I'm actually sending the "right" signal.

gekich commented 5 months ago

Hey, @rdefeo Sorry for the late response. Sure, i'll try to help you with testing:

  • Does this problem happen with non-KeyLoq files?

Just tested the Princeton protocol, and the Key property of the .sub file is not updating at all for this protocol. So, I'll assume the problem does not reproduce with non-KeyLoq files, or at least with the Princeton.

  • Would you be able to send me those files?

Yes, sure. Please leave your email, and I'll send them to you, or ↙️

or contact me on signal `yevhen.94`
  • Does this happen in both Horizontal and Vertical layouts?

Yes, the same behaviour for different modes.

  • Are you able to run the cli interface with log and then verify what it's transmitting with each button press?

I'll attach CLI dump. There were two button 4 clicks, followed by one 6 click. cli-dump.txt

rdefeo commented 5 months ago

Thank you! My email is rdefeo at gmail.com. I wonder if I need the /ext/subghz/assets/keeloq_mfcodes and /ext/subghz/assets/keeloq_mfcodes_user files as well in order to play your .sub files? Can you mail those as well?

gekich commented 5 months ago

Sent you an email

It's also worth mentioning that I'm using an external cc1101 module, however the issue is reproduced with or without it.

rdefeo commented 4 months ago

I just pushed a change that ensures RAW subghz signals are repeated, just like in the ufbt cli console app. Also added a SubGHz Repeat setting, which defaults to 10. Hopefully this helps