search

rdegges / django-twilio

A simple library for building twilio-powered Django webapps.
http://django-twilio.rtfd.org/
The Unlicense
327 stars 111 forks source link

Add support for Django 4.2 #223

Closed waleoyediran closed 1 year ago

waleoyediran commented 1 year ago

Bump the django version requirements to 4.2 Include test configuration for django 4.2

pfcodes commented 1 year ago

Please merge

waleoyediran commented 1 year ago

Hi @pfcodes I dont have write access to merge. Can you do it instead?

pfcodes commented 1 year ago

Hi @pfcodes I dont have write access to merge. Can you do it instead?

That was an open message meant to be seen by a maintainer. I don't have access either. Also this PR needs one more change in setup.py:

django_python_version_install = "Django>=4.0,<4.2"

should be changed to 

django_python_version_install = "Django>=4.0,<4.3"

or the resolution error still happens

jheld commented 1 year ago

Hi @pfcodes I dont have write access to merge. Can you do it instead?

That was an open message meant to be seen by a maintainer. I don't have access either. Also this PR needs one more change in setup.py:

django_python_version_install = "Django>=4.0,<4.2"

should be changed to

django_python_version_install = "Django>=4.0,<4.3"

or the resolution error still happens

Hi all, agreed we will need that variable adjusted, too.

waleoyediran commented 1 year ago

Should be good to merge now.