search

rdegges / flask-dynamo

DynamoDB integration for Flask.
http://flask-dynamo.readthedocs.org/en/latest/
The Unlicense
141 stars 36 forks source link

Add support for EC2 instance profile credentials #8

Closed memory closed 9 years ago

memory commented 9 years ago

Or rather, get out of boto's way in this situation: having no credentials specified in the running environment is occasionally the correct thing to do.

dcosson commented 9 years ago

+1

I wouldn't even say "occasionally" and wouldn't log a warning. (I just find it way simpler to use iam instance profiles rather than passing credentials on EC2).

@rdegges any chance of getting this and the other open PR's merged?

boivie commented 9 years ago

@rdegges: Could you have a look at this one? I agree with @dcosson that there shouldn't be a warning log since this is perfectly fine when using IAM roles. I am maintaining my own fork with a similar commit added, but I'd rather not.

rdegges commented 9 years ago

Sorry for being so lazy and slow on this ya'll. My work life has been sorta crazy. I'm going to remove the logging, but keep the rest of the stuff so that Boto can do it's thing.

My initial intent was to avoid letting boto do it's thing as I wanted to use prefixed configuration names to match the package name. In all honesty though, it's just too much work to replicate the boto stuff for such a small library =)

rdegges commented 9 years ago

New release just cut with this stuff included. Hope it helps!

memory commented 9 years ago

Awesome, thanks!

On Sun, Mar 29, 2015 at 4:37 AM, Randall Degges notifications@github.com wrote:

New release just cut with this stuff included. Hope it helps!

— Reply to this email directly or view it on GitHub https://github.com/rdegges/flask-dynamo/pull/8#issuecomment-87371556.

Everyone knows history moves in circles; the surprise is how big the circles are. (--Greil Marcus)

boivie commented 9 years ago

@rdegges Thanks a lot!