search

rdegges / python-ipify

The official client library for ipify: A Simple IP Address API.
The Unlicense
133 stars 34 forks source link

linux_distribution in platform is deprecated in Python 3.5 and removed in Python 3.8 #11

Open Tridacnid opened 4 years ago

Tridacnid commented 4 years ago

linux_distribution in platform is deprecated in Python 3.5 and removed in Python 3.8

Remove linux_distribution import. Replace the call to linux_distribution for Linux systems with the human readable output of platform().

Example Linux USER_AGENT: python-ipify/1.0.0 python/3.8.3 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5 or python-ipify/1.0.0 python/2.7.18 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5

Update .gitignore to exclude JetBrains workspace junk.

Tested on Manjaro with Python 3.8 and Python 2.7

Tridacnid commented 4 years ago

If you have a different string you'd like pulled into the USER_AGENT just let me know.

Tridacnid commented 4 years ago

Wow, I see there are multiple pulls open for this (#7, #8, #9, #10).

Tridacnid commented 4 years ago

@timotree, @akasto, @yearski, @adrian-soto Have any of you forked this project and published it as an alternative? It uses the UNLICENSE so there shouldn't be any problem putting out a clone on Pypi. Doesn't seem like it's actively maintained if some of these PRs are open from 6+ months ago.

timotree commented 4 years ago

@Tridacnid No, I haven't bothered since it's much easier to just use requests and make the request without an additional dependency

Tridacnid commented 4 years ago

Yep, makes sense.

yearski commented 4 years ago

@timotree, @akasto, @yearski, @adrian-soto Have any of you forked this project and published it as an alternative?

Since ipify.org is owned/mantained by @rdegges, I didn't want to make any assumptions about how he might want to USER_AGENT string to appear with this client for any logging he might care to do on the server. Obviously it's a very minor point so I just patch the files as it's just a few lines of code.

solintllc-robert commented 3 years ago

I emailed the developer at the email address listed here asking if he wouldn't mind reviewing the open pull requests. Fingers crossed.

rdegges commented 3 years ago

Hey all, this project is now owned by WhoisXML -- they have a developer who works on this.

mblahay commented 3 years ago

@rdegges , do you have a contact for the new maintainer? Everything on PyPI, github, and ipify still points to you. Which of the three that have been mentioned does WhoisXML own and when did the transfer of responsibility happen?

nwithan8 commented 3 years ago

I have forked and updated this package and released it on PyPi as ipify2: https://pypi.org/project/ipify2/

LastedApple3 commented 3 years ago

@rdegges could you update the website to include ipify2 in the list of module? It would be most useful for anyone who needs to do use it, not look in the responses of a pull request of the broken one that is currently linked.

SigireddyBalasai commented 1 year ago

i am creating new module with syncronous asyncronous and cli named PyIpify