test_return_ip_address actually validates ip

rdegges / python-ipify

The official client library for ipify: A Simple IP Address API.

The Unlicense

133 stars 34 forks source link

test_return_ip_address actually validates ip #5

Closed lethargilistic closed 8 years ago

lethargilistic commented 8 years ago

Before, it was just validating the truthiness of the IP returned by the API. If it returned a filled dict or list, that test would pass. This creates IP4 and IP6 sockets to test for an IP properly.

rdegges commented 8 years ago

Awesome PR, thanks =)