search

rdegges / python-ipify

The official client library for ipify: A Simple IP Address API.
The Unlicense
138 stars 35 forks source link

Support python3.8 #9

Closed akasto closed 3 years ago

akasto commented 4 years ago
nwithan8 commented 3 years ago

I do not believe removing 2.7 compatibility is the right move.

Python 2 reached EOL on Jan. 1, 2020. https://www.python.org/doc/sunset-python-2/ It's time to move on.

mblahay commented 3 years ago

Like it or not, Python 2 is used, and supported to some extent, out in the wild. Besides, an email I received from this repo's owner said that he was no longer in control of changes to ipify. This means that pull requests here are not going to see the light of day. It might be better to leave this one alone and create a fork that is compatible with Python 3. Call it ipify3, then 2 and 3 can be supported.

nwithan8 commented 3 years ago

Like it or not, Python 2 is used, and supported to some extent, out in the wild. Besides, an email I received from this repo's owner said that he was no longer in control of changes to ipify. This means that pull requests here are not going to see the light of day. It might be better to leave this one alone and create a fork that is compatible with Python 3. Call it ipify3, then 2 and 3 can be supported.

Done and done. Available on PyPi https://github.com/nwithan8/ipify2