rdeits / MeshCat.jl

WebGL-based 3D visualizer in Julia
MIT License
233 stars 42 forks source link

`RotMatrix` from `Rotations.jl` is not being brought into scope #168

Closed ferrolho closed 4 years ago

ferrolho commented 4 years ago

Hi, Robin! :slightly_smiling_face: Hope you are doing well.

I think RotMatrix is missing from this using: https://github.com/rdeits/MeshCat.jl/blob/83c435cb40db9a8cec140192337a3291b902633e/src/MeshCat.jl#L4

RotMatrix is used by this method: https://github.com/rdeits/MeshCat.jl/blob/83c435cb40db9a8cec140192337a3291b902633e/src/atframe.jl#L32

Currently, with MeshCat v0.11.2, an error is thrown for snippets calling that js_quaternion method:

using MeshCat
MeshCat.js_quaternion(rand(3,3))
ERROR: UndefVarError: RotMatrix not defined
Stacktrace:
 [1] js_quaternion(::Array{Float64,2}) at /home/henrique/.julia/packages/MeshCat/ECbzr/src/atframe.jl:32
 [2] top-level scope at REPL[5]:1