search

rdeits / MeshCat.jl

WebGL-based 3D visualizer in Julia
MIT License
233 stars 42 forks source link

Renames `UnitQuaternion` to `QuatRotation` #210

Closed ferrolho closed 2 years ago

ferrolho commented 2 years ago

See Rotations.jl v1.1.0 (https://github.com/JuliaGeometry/Rotations.jl/releases/tag/v1.1.0).

ferrolho commented 2 years ago

Hi, Robin! Let me know if you are happy with these changes. I asked for advice regarding one of the changes here. I chose to change the code with minimal effort, but I guess the drawback is that we are again relying on the field names used in the internal structure of quaternions.

ferrolho commented 2 years ago

Thank you, Robin! Any chance you can tag a new release to cover these changes?

ferrolho commented 2 years ago

Thank you, Robin! Any chance you can tag a new release to cover these changes?

@rdeits

rdeits commented 2 years ago

done! Sorry for the delay, we just had a baby :)

rdeits commented 2 years ago

https://github.com/JuliaRegistries/General/pull/50380

ferrolho commented 2 years ago

done! Sorry for the delay, we just had a baby :)

That's amazing news, Robin! Congratulations!! :baby: Best of luck!

And thank you for the new version release. :stuck_out_tongue: