search

rdeits / MeshCat.jl

WebGL-based 3D visualizer in Julia
MIT License
234 stars 43 forks source link

Compatibility updates for GeometryBasics #211

Closed ferrolho closed 2 years ago

ferrolho commented 2 years ago

Renames Point3f0 to Point3f, following https://github.com/JuliaGeometry/GeometryBasics.jl/pull/97.

I did run the script provided in the PR link above to rename other types, but these were the only occurrences that needed renaming.

ferrolho commented 2 years ago

I should mention that watching this package's unit tests running was the most entertaining unit testing I have ever experienced.

Screenshot from 2021-12-01 14-53-02

ferrolho commented 2 years ago

Hmm, do you know why the GitHub checks are failing, @rdeits? I'm guessing it's something with the GitHub actions since all tests passed on my local machine.

ferrolho commented 2 years ago

Never mind what I said in the comment above. This is now ready to be merged.

ferrolho commented 2 years ago

When this is merged, we can also just close https://github.com/rdeits/MeshCat.jl/pull/201.

rdeits commented 2 years ago

Thank you again!