rdeits / MeshCat.jl

WebGL-based 3D visualizer in Julia
MIT License
233 stars 42 forks source link

Constrain WebSockets.jl version to <1.6 #235

Closed ferrolho closed 1 year ago

ferrolho commented 1 year ago

Constraining WebSockets.jl to versions <1.6 fixes #234 ~but is also causing the Windows CI pipeline to fail~.

Edit 1: Actually, this is not the breaking change. Something else must have broken the pipeline, because after having run the pipeline for the previous master today, that one is failing too (when previously it was succeeding).

Edit 2: I have decided to temporarily disable the Windows runner from the CI and move the task for fixing it to #236.

rdeits commented 1 year ago

Nice, thanks for finding the root cause here. It's annoying to restrict the WebSockets version, but it's much better than just being broken.