rdeits / MeshCat.jl

WebGL-based 3D visualizer in Julia
MIT License
234 stars 43 forks source link

JSExpr warnings #52

Closed tkoolen closed 6 years ago

tkoolen commented 6 years ago

Now that https://github.com/JuliaGizmos/JSExpr.jl/pull/14 is in, I'm getting:

julia> Pkg.test("MeshCat")
INFO: Computing test dependencies for MeshCat...
INFO: No packages to install, update or remove
INFO: Testing MeshCat
WARNING: eval from module JSExpr to MeshCat:    
Expr(:call, :macroexpand, quote Expr(:macrocall, :@var, :element = Expr(:ref, Expr(:., Expr(:., :this, Expr(:quote, :dom)::Any)::Any, Expr(:quote, :children)::Any)::Any, 0)::Any)::Any end)::Any
  ** incremental compilation may be broken for this module **

WARNING: eval from module JSExpr to MeshCat:    
Expr(:call, :macroexpand, quote Expr(:macrocall, :@new, Expr(:call, Expr(:., :mc, Expr(:quote, :Viewer)::Any)::Any, :element)::Any)::Any end)::Any
  ** incremental compilation may be broken for this module **
rdeits commented 6 years ago

Oh no... Yeah, this is easy to reproduce by creating a new package with:

__precompile__()

module Foo

using JSExpr
function foo()
    @js function()
      @new x
    end
end
end

(needs to be a package, not just a module, so it will be precompiled and generate the warning). Looks like https://github.com/JuliaGizmos/JSExpr.jl/pull/14 was the wrong fix

tkoolen commented 6 years ago

This was fixed.