search

rdeits / MeshCat.jl

WebGL-based 3D visualizer in Julia
MIT License
234 stars 43 forks source link

Test failure on Travis #76

Closed tkoolen closed 5 years ago

tkoolen commented 5 years ago

See https://travis-ci.org/rdeits/MeshCat.jl/jobs/462534932#L892-L926. I can take a look later today if it's not a trivial fix for you, @rdeits.

rdeits commented 5 years ago

Sorry, this probably isn't something I can fix right now at work, but I think the problem is this line: https://github.com/rdeits/MeshCat.jl/blob/5d191c879170455f5ee3103ec8d7c172cb9e70a7/src/geometry.jl#L46

I vaguely recall something about how SDiagonal was going to change in a recent version of StaticArrays--it looks like I was relying on the old behavior in some way. That intrinsic_transform gets passed to https://github.com/rdeits/MeshCat.jl/blob/3b46aea655141c0441051183ec79a28886dc8744/src/lowering.jl#L13-L17 which probably used to return a plain Vector but now returns some reshaped object when used with a transform built from SDiagonal.

tkoolen commented 5 years ago

Thanks for the lead!