search

rdelrosario / xamarin-plugins

Cross platform Xamarin & Windows plugins for PCLs
MIT License
179 stars 161 forks source link

Doesn't even subscribe #44

Closed kentcb closed 8 years ago

kentcb commented 8 years ago

I'm at a loss as to how this could ever work on Android. The PushNotificationRegistrationIntentService class defines a SubscribeTopics method, but nothing ever calls it! See here. Therefore, the client is never subscribed to any topic. :/

rdelrosario commented 8 years ago

It actually works without this change. But makes sense, will see if this has any impact on functionality.

kentcb commented 8 years ago

Can you explain how it would work without a subscription? I assure you, I spent hours debugging through Android notifications yesterday and was simply unable to receive any notification without a subscription. Having said that, once I added the subscription I started receiving two notifications. I've still not tracked down the cause, but it sure looks like a server issue, not client.

This would also explain #40.

kentcb commented 8 years ago

OK, I think I've figured this out and solved #46 at the same time (it's related). Will PR shortly.

kentcb commented 8 years ago

Note that I have solved #46 via #49. However, I was wrong about not requiring a subscription any more. A subscription is still required and I still don't understand how that could ever not be the case.

rdelrosario commented 8 years ago

It really have worked fine without this change. I even made a sample a few months ago using Parse. But this sample could be use with any REST API:

https://github.com/CrossGeeks/Xamarin.Samples/tree/master/Xamarin.Android

nsw2206 commented 8 years ago

I'm not getting any push notifications. Have initialized in Main Activity, not as application class. How do I try with Kents mods?