search

rdelrosario / xamarin-plugins

Cross platform Xamarin & Windows plugins for PCLs
MIT License
179 stars 161 forks source link

Problem with intent filters #97

Closed tanis2000 closed 7 years ago

tanis2000 commented 7 years ago

I just noticed that you have this line of code where you define an IntentFilter for a sample package name:

https://github.com/rdelrosario/xamarin-plugins/blob/master/PushNotification/PushNotification/PushNotification.Plugin.Android/AppUpdateReceiver.cs#L15

When Xamarin compiles the application using this library, it adds that filter to the manifest with that fake package name. I noticed that you cannot override that attribute because IntentFilters can be defined more than once per class, so it would just try to add one more intent filter resulting in a malformed manifest.

Are you aware of any way to remove an IntentFilter from the hosting project or could you just remove that line and release an updated version of this library eventually?

Cheers!

rdelrosario commented 7 years ago

just removed this line on latest prerelease: https://www.nuget.org/packages/Xam.Plugin.PushNotification/1.2.5-beta