search

rdemaria / pytimber

Python Wrapping of CALS API
12 stars 23 forks source link

fix lsf unit change #64

Closed loiccoyle closed 5 years ago

loiccoyle commented 5 years ago

here is the quick fix for the geometric emittance I mentioned last week.

For some reason the unit of the lsfh & lsfv data changed from 2018-01-01 onward.

pep8speaks commented 5 years ago

Hello @loiccoyle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 138:3: E111 indentation is not a multiple of four Line 154:7: E114 indentation is not a multiple of four (comment) Line 155:7: E111 indentation is not a multiple of four Line 161:7: E111 indentation is not a multiple of four

Comment last updated at 2019-03-05 13:18:05 UTC
rdemaria commented 5 years ago

Thanks a lot! Can you fix the style issues?

loiccoyle commented 5 years ago

The entire LHCBSRT.py file does not respect PEP8... I can pass it through a PEP8 formater if that helps.

levens commented 5 years ago

For this PR it would probably be best to just fix the issues on the lines you touch and to submit a full clean-up of the file as a separate PR with no code changes.

loiccoyle commented 5 years ago

Only the 2 wide indentations remain, as they are throughout the file

rdemaria commented 5 years ago

For this PR it would probably be best to just fix the issues on the lines you touch and to submit a full clean-up of the file as a separate PR with no code changes.

Ok, if you could do that it would be great. I merge the PR in the meanwhile...