search

rdevon / cortex

A machine learning library for PyTorch
BSD 3-Clause "New" or "Revised" License
92 stars 25 forks source link

removing arch (and moving some models to be converted) #118

Closed rdevon closed 6 years ago

rdevon commented 6 years ago

arch is old models used for research. The common ones are to moved to built-ins. Others are being moved to private repos

rdevon commented 6 years ago

Just removes arch from the repo

ReyhaneAskari commented 6 years ago

@rdevon are you planning to bring this code later to cortex or your other PR (https://github.com/rdevon/cortex2.0/pull/111/) have these?

rdevon commented 6 years ago

@ReyhaneAskari Most of the code actually is supposed to be private (part of current research) minus the models that I need to port over (which I moved to built-ins)

ReyhaneAskari commented 6 years ago

@rdevon , I see. But there are going to be in the history anyways. Are you ok with that?

rdevon commented 6 years ago

@ReyhaneAskari for now, yes. We can decide whether to make the hard decision of force-removing the history, but this needs to be done carefully.

rdevon commented 6 years ago

@joeljpoulin I agree. This might be best to do when we merge to master though because some of the history is mixed in there.