search

rdevon / cortex

A machine learning library for PyTorch
BSD 3-Clause "New" or "Revised" License
92 stars 25 forks source link

Reloading #160

Closed rdevon closed 6 years ago

rdevon commented 6 years ago

Fixes several bugs and provides some enhancements.

Some issues related to #62 are addressed here, though import / pickling is still an issues.

CelebA is enhanced and can now handle splits. Imagenet now uses the common preprocessing. STL-10 added and uses the common preprocessing.

kwargs were not propagating properly through submodels.

Default arguments were not passing properly. This has been probably fixed, but testing is necessary (#141 ).

Attribute classification was added (for CelebA)

rdevon commented 6 years ago

@joeljpoulin I don't know if either of those ways to edit the defaults or the ARGS that unexpected behavior. Both behave like dicts when edited directly like that, and they need to be updated using: https://github.com/rdevon/cortex2.0/blob/reloading/cortex/_lib/parsing.py#L330 or https://github.com/rdevon/cortex2.0/blob/reloading/cortex/_lib/__init__.py#L103-L112

What exactly are you trying to test here?