Fix model_optimizer_options argument

rdevon / cortex

A machine learning library for PyTorch

BSD 3-Clause "New" or "Revised" License

92 stars 25 forks source link

Open dmitriy-serdyuk opened 6 years ago

dmitriy-serdyuk commented 6 years ago

Either I do not understand how to use option model_optimizer_options or it will not work with current implementation.

This PR allows to write --o.model_optimizer_options "encoder={'lr': 0.01}".

dmitriy-serdyuk commented 6 years ago

Actually, why do you need this argument? I can see now that that --o.optimizer_options supports passing a dictionary.

rdevon commented 6 years ago

@dmitriy-serdyuk Can you rebase this to dev? I think there might be some overlapping in the branches

dmitriy-serdyuk commented 6 years ago

Done

rdevon commented 6 years ago

@dmitriy-serdyuk OK good. I'll fix the flake errors with dev and start merging.