rdfhdt / hdt-cpp

HDT C++ Library and Tools
115 stars 65 forks source link

Test case "properties" fails #256

Closed donpellegrino closed 2 years ago

donpellegrino commented 2 years ago

Running the "properties" test case (make check) fails with the following error:

~/src/hdt-cpp/libhdt/tests$ cat test-suite.log
===============================================
   libhdt 1.3.3: libhdt/tests/test-suite.log
===============================================

# TOTAL: 11
# PASS:  10
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: properties
================

Catch exception load: Error: The subjects must be correlative.
Error: The subjects must be correlative.
terminate called after throwing an instance of 'std::runtime_error'
  what():  Couldn't read header
FAIL properties (exit status: 134)

This error message comes from BitmapTriples.cpp:

~/src/hdt-cpp$ grep -r "The subjects must be correlative."
libhdt/src/triples/BitmapTriples.cpp:                throw std::runtime_error("Error: The subjects must be correlative.");

All three preset configurations run by the properties test case use triples.type <http://purl.org/HDT/hdt#triplesBitmap>:

        std::vector<std::string> elem = {
                "../presets/dictionaryfour.hdtcfg",
                "../presets/dictionaryliteral.hdtcfg",
                "../presets/ops.hdtcfg"};
donpellegrino commented 2 years ago

Sorry, I discovered this was my own fault. I added a commit to the Pull Request for Issue #244 that fixes the problem. I confirmed that Pull Request and all my other Pull Requests that had the code from that branch pass the default test suite without any errors or warnings.

Getting the tests to execute required the code I did for Issue #254 as well.