rdfhdt / hdt-java

HDT Java library and tools.
Other
94 stars 69 forks source link

Fix non closed files #164

Closed ate47 closed 1 year ago

ate47 commented 2 years ago

This pull request fix (I hope) all the non closed files and mapped buffer in HDT-JAVA-CORE, the main idea is to make it work on Windows, more strict on not closed files.

API Changes

I've added to the indexedHDT(...) method a throws IOException to throw exception instead of a random runtime exception (probably a NPE) in case of error.

Old HDTManager.java

HDT indexedHDT(HDT hdt, ProgressListener listener)
protected abstract HDT doIndexedHDT(HDT hdt, ProgressListener listener)

New HDTManager.java

HDT indexedHDT(HDT hdt, ProgressListener listener) throws IOException
protected abstract HDT doIndexedHDT(HDT hdt, ProgressListener listener) throws IOException

Core Changes

Main

Tests

Workflow