search

rdfio / RDFIO

RDF triples import, export and PHP SPARQL endpoint for Semantic MediaWiki
http://www.mediawiki.org/wiki/Extension:RDFIO
Other
29 stars 12 forks source link

Support for other wiki languages than English #41

Closed samuell closed 7 years ago

samuell commented 7 years ago

We have some stupid hard-coded strings which might be different for different languages.

See this screenshot of code climate for hints on where to fix it:

selection_296

Looking into it.

samuell commented 7 years ago

Do @mwjames or @kghbln have some input on the most idiomatic way to access i18ed NSes?

I found something about the SMW_NS_PROPERTY constant ... but still looking for the best way to access the i18n version ...

samuell commented 7 years ago

I think I know the solution now:

$titleWithNS = Title::makeTitleSafe( SMW_NS_PROPERTY, $theTitle )->getFullText();

... etc.

(EDIT: getTitleValue() → getFullText())

samuell commented 7 years ago

The changes are now implemented, as of cca71be1976a78f4a8f65d986e7fec35e382974a and fcd282346d839e448a1eceee8e943d1a148ed53f . Now just need to test this with another language somehow.

samuell commented 7 years ago

This is now tested manually, so closing (a CI would still be great).