search

rdfjs / N3.js

Lightning fast, spec-compatible, streaming RDF for JavaScript
http://rdf.js.org/N3.js/
Other
714 stars 130 forks source link

Circular imports #381

Closed martines3000 closed 6 months ago

martines3000 commented 6 months ago

Hi. I found that 2 files have circular imports.

N3DataFactory.js and N3Utils.js

https://github.com/rdfjs/N3.js/blob/51a41564467252278f4b8b5998453ad88f607ced/src/N3DataFactory.js#L5

https://github.com/rdfjs/N3.js/blob/51a41564467252278f4b8b5998453ad88f607ced/src/N3Util.js#L3

RubenVerborgh commented 6 months ago

Is there a situation where this leads to problems? This is compiled away.

martines3000 commented 6 months ago

Its compiled away in the browser version (n3.min.js), but the cyclic import is still there in the lib folder on NPM.

Its causing some errors and I also get a warning from rollup about circular dependencies.

RubenVerborgh commented 6 months ago

Ok, let me look into it!

martines3000 commented 6 months ago

Thank you, much appreciated. 💯