Fix DatasetFactory parent

rdfjs / dataset-spec

RDF/JS: Dataset specification 1.0 – This specification provides a definition how to store multiple quads in a so-called dataset.

https://rdf.js.org/dataset-spec/

6 stars 5 forks source link

Fix DatasetFactory parent #57

Open thewilkybarkid opened 4 years ago

thewilkybarkid commented 4 years ago

Refs https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40794#discussion_r353170046.

thewilkybarkid commented 4 years ago

I think another possibility would be to have DatasetCoreFactory extend DataFactory, then we could have DatasetFactory extend DatasetCoreFactory?

Could also just use unions of the two (reduces the requirements on implementing Dataset(Core)Factory).

retog commented 4 years ago

@ktk feel like reviewing this one too? It seems quite an obvious improvement compared with the status quo.

Btw, how does one get the review privilege?