search

rdfjs / types

Authoritative TypeScript typings for all RDFJS specifications
MIT License
17 stars 13 forks source link

Add queryable interfaces #30

Closed rubensworks closed 2 years ago

rubensworks commented 2 years ago

This PR implements the latest state of the new query spec as defined in https://github.com/rdfjs/query-spec/

This PR should not be merged yet into master until the query spec is stable. In the meantime, prereleases of this package are being published to npm for testing purposes. At the time of writing 1.1.0-next.0 of @rdfjs/types is available on npm.

@jacoscaz I changed some small things while experimenting with these interfaces in Comunica. Nothing major was changed, just some things to simplify the implementation of them. All interfaces (except for the filterable ones) have been implemented in Comunica, and have been confirmed to work as intended.

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 09ad6310c9a56058448397ed5dcca39fd43394df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | @rdfjs/types | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

rubensworks commented 2 years ago

No indeed, won't merge yet. Just published 1.1.0-next.1 for whoever is interested.

rubensworks commented 2 years ago

I've removed the filterable interfaces from this PR for now into #31, since no implementations of this interface exist yet, and it may take a longer time to stabilize.

This PR has been open for a week now. Unless there are any objections, I'll wait another week (until February 17) to merge this.

rubensworks commented 2 years ago

Pinging some people who may want to have another look at this: @gsvarovsky @tpluscode

rubensworks commented 2 years ago

Closing thought: for a large PR with many new pieces, it would be wise to add some tests :)

Right, will look into that.

rubensworks commented 2 years ago

I just added some tests (I didn't aim for full coverage though, just the most critical parts for now)

rubensworks commented 2 years ago

All issues should be resolved now. Unless there are any other comments, I'll merge this on Thursday (after fixing the changelog).