Closed jacoscaz closed 2 years ago
Latest commit: d47c8b12f8856210c3c7fb2c9d0cfd7ead0a7d1f
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@rubensworks I did a small amount of manual testing to verify whether methods get correctly overloaded across interfaces but this could definitely do with more testing. Might be a good starting point for actual type tests, as per @tpluscode's comment in the other PR. I was waiting for preliminary feedback before committing further effort.
Might be a good starting point for actual type tests, as per @tpluscode's comment in the other PR. I was waiting for preliminary feedback before committing further effort.
Yep, I'm already working on those as we speak in #30
EDIT: I should premise that this PR builds on the
feature/query
branch, for which there is already an open PR at https://github.com/rdfjs/types/pull/30 .This PR was inspired by @tpluscode's feedback as discussed on Gitter.im. The goal is to break down
Queryable
andSparqlQueryable
into simpler, more modular interfaces that can be combined without loss in expressivity. I've opted to break them down based on query type (string vs. Algebra).Example of what becomes possible with this PR: