rdfjs / types

Authoritative TypeScript typings for all RDFJS specifications
MIT License
17 stars 13 forks source link

@rdfjs/types 1.1.1 exported to npm as empty package #49

Closed Renegade334 closed 1 month ago

Renegade334 commented 1 month ago

https://www.npmjs.com/package/@rdfjs/types/v/1.1.1?activeTab=code

The latest @rdfjs/types package has just been pushed to npm... without any types!

Understandably, this is causing some ecosystem issues... 😉

(@rdfjs @tpluscode et al.)

jeswr commented 1 month ago

cc @matthieubosquet - I suspect this comes from https://github.com/rdfjs/types/pull/47

tpluscode commented 1 month ago

Good grief. Fixing ASAP

matthieubosquet commented 1 month ago

I am not familiar with the @changeset/cli and I am surprised that it is inconsistent with npm pack.

Note that when I run npm pack locally on the up to date master branch of this repo, I still get the intended files:

Screenshot 2024-09-17 at 16 33 46

I notice a lot of warnings on the release action run.

I looked up changeset but none of the commands gave me anything explicit as to how the package is created.

tpluscode commented 1 month ago

It should be consistent, of course, and I'm surprised we ran into that issue. Investigating now

tpluscode commented 1 month ago

The warnings show we're using an old version of the changesets action. Could be the reason for failure

tpluscode commented 1 month ago

I unpublished the 1.1.1 version from NPM

matthieubosquet commented 1 month ago

I also tried a npm publish --dry-run which works as expected:

Screenshot 2024-09-17 at 17 02 58

So, a manual publish from local should work if you can do that @tpluscode (and thank you for jumping on this so promptly).

matthieubosquet commented 1 month ago

Apparently the issue is with yarn. When I run yarn pack, the declaration files are not included.

There are open issues on GitHub about yarn pack behaving inconsistent with npm pack.

tpluscode commented 1 month ago

That's an interesting find. yarn v1 is EOL anyway, so we might just switch to npm

matthieubosquet commented 1 month ago

@tpluscode I found a file pattern that works with both yarn and npm: "**/*.d.ts" (see PR #50, requires deleting v1.1.1 tag and release).

I prefer using npm but it looks like changeset is for yarn and I don't know if others have preferences or know of tooling that they would like to use in the release process.

I personally use a very simple action that triggers on GitHub Release to publish my packages to npm.

tpluscode commented 1 month ago

Changesets do not depend on yarn and will use the correct package manager used in a project (npm or pnpm, where applicable). In fact, I think that npm is the default fallback.

matthieubosquet commented 1 month ago

Changesets do not depend on yarn and will use the correct package manager used in a project (npm or pnpm, where applicable). In fact, I think that npm is the default fallback.

That's great to know (and makes way more sense)! I was confused because all the changeset action examples use yarn. That makes it easier.