search

rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
698 stars 342 forks source link

adding robotControllerAxis variables to JointControlInfo_RobotController #1187

Closed MiraiHattori closed 1 year ago

MiraiHattori commented 1 year ago

Some intParameters and floatParameters in robotmotionparameters would be better in each jointInfo, so in preparation to the change I added robotControllerAxis{Mult|Offset|ProductCode} in JointControlInfo_RobotController.

MiraiHattori commented 1 year ago

@kanbouchou could you review this PR?

kanbouchou commented 1 year ago

@MiraiHattori please make sure to bump version.

MiraiHattori commented 1 year ago

@kanbouchou sorry for not bumping version. just bumped. I changed the robotControllerAxis* variable order in the code since I've noticed it was not constant in the code.

kanbouchou commented 1 year ago

@MiraiHattori thanks, looks good to me.

@rdiankov can you please check?

rdiankov commented 1 year ago

thanks~