rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
696 stars 342 forks source link

visualization on cropping margin #1228

Closed LLipter closed 1 year ago

LLipter commented 1 year ago

Screenshot from 2023-05-02 10-38-39 Screenshot from 2023-05-02 10-38-56

ziyan commented 1 year ago

@rdiankov I am not sure if:

  1. you need planes instead of lines, as it is hard to see if something is protruding the margin or not with the lines, but it might be too intrusive
  2. you need the ability to turn off this visualization, as it is always on right now

And Ran was also asking if you need the same visualization for crop container empty margins as well, but that's even more clutter on the screen.

Another alternative approach would be to use the visualization manager route.

rdiankov commented 1 year ago

please also add visualization for empty container margins. red is not a good color, that's usually reserved for obstacles. perhaps you should use a shade of the geometry color

LLipter commented 1 year ago

I move this branch to rdiankov:oprenrave repo. See pull request https://github.com/rdiankov/openrave/pull/1231