rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
696 stars 342 forks source link

make PyEnvironmentBase a public API #1232

Closed LLipter closed 1 year ago

LLipter commented 1 year ago

Ziyan asked me to write a unified NotifyEnvironmentChanged implementation. While working on it, I realize I need to have access to PyEnvironmentBase in order to make python binding work. Can we mark this class as a public openrave API?

rdiankov commented 1 year ago

It's private for a reason, so no. We have a c++ implementation of NotifyEnvironmentChanged, why not use that?