Closed kanbouchou closed 1 year ago
will make some changes based on offline discussions, setting to draft until completed.
will make some changes based on offline discussions, setting to draft until completed.
@rdiankov please review again, the final change set is basically to make sure that in call path of adding to environment, make sure we don't invalidate hash. I didn't need to add logic to invalidate hash when related properties changes, it was already all taken care of.
@rdiankov changed variable name as discussed offline, from __hashKinGeomDyn
to __hashKinematicsGeometryDynamics
thanks
Background
__hashkinematics
, but it was reset inside_ComputeInternalInformation
and_PostprocessChangedParameters
both called fromEnvironment::Add
Proposal
_ComputeInternalInformation
, do not invalidate kinematics geometry hash.KinBody::Prop_LinkDynamics
to_PostprocessChangedParameters
when callingEnvironment::Add
as dynamics properties should not be changed during this process.cc @yoshikikanemoto