rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
696 stars 342 forks source link

Avoid clearing Kinematics Geometry hash when adding to environment #1240

Closed kanbouchou closed 1 year ago

kanbouchou commented 1 year ago

Background

Proposal

  1. Inside _ComputeInternalInformation, do not invalidate kinematics geometry hash.
  2. Do not pass KinBody::Prop_LinkDynamics to _PostprocessChangedParameters when calling Environment::Add as dynamics properties should not be changed during this process.

cc @yoshikikanemoto

kanbouchou commented 1 year ago

will make some changes based on offline discussions, setting to draft until completed.

kanbouchou commented 1 year ago

will make some changes based on offline discussions, setting to draft until completed.

@rdiankov please review again, the final change set is basically to make sure that in call path of adding to environment, make sure we don't invalidate hash. I didn't need to add logic to invalidate hash when related properties changes, it was already all taken care of.

kanbouchou commented 1 year ago

@rdiankov changed variable name as discussed offline, from __hashKinGeomDyn to __hashKinematicsGeometryDynamics

rdiankov commented 1 year ago

thanks