rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
696 stars 342 forks source link

Fixed document generation #1247

Closed cielavenir closed 1 year ago

cielavenir commented 1 year ago

https://pybind11.readthedocs.io/en/stable/classes.html#dynamic-attributes

NOTE: THIS IS DRAFT, py::dynamic_attr SHOULD BE AVOIDED. avoided done.

@felixvd

rdiankov commented 1 year ago

not sure i like this..

cielavenir commented 1 year ago

@felixvd With the current state, make will work (with preparing ikfaststats.pp) but please find a way to run openrave.py shell-block while openrave python3 dir symlinked.

cielavenir commented 1 year ago

@felixvd one my idea is https://github.com/rdiankov/openrave/pull/1250

cielavenir commented 1 year ago

@felixvd sorry I have to break this branch. c4d538c is known to work.

The error message is:

Traceback (most recent call last):py/databases.convexdecomposition                                                                                                                                                 
  File "/home/mujin/mujin/jhbuildappcontroller/install/bin/openrave.py", line 52, in <module>
    import openravepy
  File "/home/mujin/mujin/checkoutroot/openrave/docs/openravepy/__init__.py", line 31, in <module>
    from .openravepy_int import *
ImportError: /home/mujin/mujin/checkoutroot/openrave/docs/openravepy/openravepy_int.so: undefined symbol: PyInstanceMethod_Type

It can be fixed after merging #1250

cielavenir commented 1 year ago

@rdiankov by the way, could you add @felixvd to the members of rdiankov:openrave?

cielavenir commented 1 year ago

@felixvd now make -C docs is passing!

cielavenir commented 1 year ago

I removed dynamic_attr, it should be ok now

cielavenir commented 1 year ago

@felixvd please check

felixvd commented 1 year ago

I confirm that the command finishes, but the doc seems to have some issues:

There are also a lot of warnings (images not found etc). Some of them may have existed for a long time and can be ignored, but we should go through them and confirm.

cielavenir commented 1 year ago

@felixvd Forgot to add docs/robots symlink. I pushed it. Could you try again?

cielavenir commented 1 year ago

I can't click on links in the frame on the right for some reason.

Can remove div.documentwrapper's "float: left;" from build/en/sphinxhtml/_static/sphinxdoc.css, but I don't know the correct way.

@felixvd It builds, so I think you can continue, right?

@rdiankov Could you give the push right to Felix?

rdiankov commented 1 year ago

thanks~