search

rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
693 stars 343 forks source link

removed wrongly exported py::init #1253

Closed cielavenir closed 1 year ago

cielavenir commented 1 year ago

some defined py::init are actually (internal) C++ API which returns Python object, so they should not be exported.

also they cause errors on pybind11-stubgen.

cielavenir commented 1 year ago

pipelineid=361375 Pipeline #561581

cielavenir commented 1 year ago

Pipeline #561697 pipelineid=361409

[edit] shit autotester is broken now

cielavenir commented 1 year ago

subset of #1254

felixvd commented 1 year ago

Autotester is fixed, resubmitted as Pipeline #561908, pipelineid=361471

cielavenir commented 1 year ago

(well, I suppose this one can be reviewed quickly so I merge produciton)

rdiankov commented 1 year ago

no regressions?

cielavenir commented 1 year ago

no regressions, according to Pipeline #561908, pipelineid=361471

rdiankov commented 1 year ago

got it, thanks