rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
693 stars 343 forks source link

add reset function to IkParameterization #1278

Closed eisoku9618 closed 1 year ago

eisoku9618 commented 1 year ago

I would like to cache IkParameterization so I need to have a way to reset its instance.

rdiankov commented 1 year ago

Will need to change minor version since this breaks binary compat

eisoku9618 commented 1 year ago

@rdiankov @yoshikikanemoto Thank you for checking. I incremented minor version and changelog.

eisoku9618 commented 1 year ago

By the way, I think this change is not a ABI breaking change as far as I read https://www.acodersjourney.com/20-abi-breaking-changes/ because the implementation is in the header file.

note to self: since our CMakeLists.txt is like this, libopenraveXXX.so.YYY does not include patch version. And any system using OpenRAVE must need to work correctly with any patch version (i.e. the target of the symbolic link should be able to be changed from libopenrave0.114.so.0.114.2 to libopenrave0.114.so.0.114.1).

set (OPENRAVE_SOVERSION ${OPENRAVE_VERSION_MAJOR}.${OPENRAVE_VERSION_MINOR})
set(OPENRAVE_LIBRARY_SUFFIX "${OPENRAVE_SOVERSION}" CACHE STRING "Suffix to append to library names")

set_target_properties(libopenrave PROPERTIES OUTPUT_NAME openrave${OPENRAVE_LIBRARY_SUFFIX}
                                  SOVERSION 0 # always have it 0 since we're including the soversion as part of the library name
                                  VERSION ${OPENRAVE_VERSION}
                                  COMPILE_FLAGS "${LIBOPENRAVE_COMPILE_FLAGS} ${FPARSER_CXX_FLAGS} -DOPENRAVE_DLL_EXPORTS -DOPENRAVE_DLL"
                                  LINK_FLAGS "${LIBOPENRAVE_LINK_FLAGS} ${FPARSER_LINK_FLAGS}")

image

rdiankov commented 1 year ago

Yes it does. You added a function in a class, everything has to be recompiled because rd signature changed

rdiankov commented 1 year ago

thanks