rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
693 stars 343 forks source link

Make the unit standard value functions constexpr #1293

Closed shossjer closed 1 year ago

shossjer commented 1 year ago

This change requires c++14 to compile but the code can if needed be changed to support c++11 by writing something like

    return unit == OpenRAVE::LU_Meter ? 1.0 :
           unit == OpenRAVE::LU_Millimeter ? 1e3 :
           ...
           throw ...;
rdiankov commented 1 year ago

Thanks~

cielavenir commented 1 year ago

don't worry, after Debian11 migration, our standard is C++14.

cielavenir commented 10 months ago

for record: this was reverted by https://github.com/rdiankov/openrave/commit/3bc6152ed7a26925c0bfc34d5bf40ac751617925