Stock Pybind11 (2.9.2) compatibility issue - Githubissues

rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.

http://www.openrave.org

Other

687 stars 340 forks source link

Stock Pybind11 (2.9.2) compatibility issue #1305

Closed lazydroid closed 10 months ago

lazydroid commented 10 months ago

Got this error when building with stock pybind11:

openrave/python/bindings/openravepy_kinbody.cpp:522:23: error: invalid conversion from ‘int’ to ‘const char*’ [-fpermissive]
  522 |     return _vGeomData[1];
      |                       ^
      |                       |
      |                       int

we should use py::to_object(0) instead of the int when trying to access the elements using subscription.

cielavenir commented 10 months ago

-----BEGIN PGP MESSAGE-----

hQIMAwAinXiLUbjzAQ//TOeM2EBMbjNbjtPiAdwJNYOaYRfqJWlBp61btIw3jmRm
64Ph3FwfCa6JybEPGYDiDMAYGs0C33G7nrE5F0mJdmfphCD7/MgsxLIlcYEp8zSG
px2kR2fTMomVpIW0freJoZuT2AX6CiR6eW5Drq4Io/nlBtcAa7vIzbwxwAk9fb2C
JNptAiGm+xaBSzKy0b7ys4nax9nMX7jTnlMySZM7M+HKITQuUE2wdi9tJutlLFKL
OjY+DYnFtBhV5RFSX/sIJzFR6STA6YOI/06wpTWHBPqf36iXrFNadzUJbDytlW28
HjIrRkxyYUCaqfpKf4l++Uv0tmBjn/Dz0nwSLeBolLCoixxzvDBMW2pcZLIn2If/
407bXTEuiXIzVaGIUdf8W4XiUw2GH4lI0uJEnNPqK3F6SF2aw0Zue0V1yh8FK1JP
/F6G66LPYNIptTx+eQKH+5goqGF1yqF26uyGhQlzo2fEt8HzzgpHp7srJnbkFt8Q
c7/maQoCX+j5Jt4WCYrdrK6tndNB8ze5VinY3YI8Qms2bXxvxxwbjPXnJsY8iPqk
VlcYtQ5osdxf6aD5t505wkYMyau3155m9Cb1e4iw0LaPSF6ymX79TJc8ZnGfKoL9
Dl+egTzREhuc9HavNOayZgl2BNS1A/Z1BLalwIdRX6Vf5ohRKfa1GGBLB6m5VwXS
ggGpBUZJrZTPbseKPR8NWsLZIF5ORI03lFUsx9JaMJSm7EGS633NSsyOD2vtMHYi
e7ZkueZtZxM4FXp+KoXO6FUymggWdLxRbfG5b54R4trlBt4hrNuab95UnnJM7unt
XMNVTjvWriD7Vmp8m/Igq2JK7G+abVgc9T9yU5ygkMaTij0=
=M4he
-----END PGP MESSAGE-----

cielavenir commented 10 months ago

new instance.

lazydroid commented 10 months ago

Pipeline: #622448

looks good to me!

rdiankov commented 10 months ago

thanks~