rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
687 stars 340 forks source link

Fix nonAdjacentLinks and _listNonCollidingLinksWhenGrabbed were affected by collision callbacks. #1322

Closed yoshikikanemoto closed 8 months ago

yoshikikanemoto commented 8 months ago

description of the issue

changes

test

cc: @Puttichai

rdiankov commented 8 months ago

Great catch~

cielavenir commented 8 months ago

@yoshikikanemoto I'm afraid but this pull request broke testopenrave/legacy/test_planning.py::test_PlanWithCollision[pr2test1.env.xml]. I confirmed that the test case passes when I revert 7a4e6348ce58e539d034a8d62a91504c3e01a5ab . Please check.

/cc @ntohge

cielavenir commented 8 months ago

Yoshiki suggested fix, pushed to https://github.com/rdiankov/openrave/pull/1327