search

rdiankov / openrave

Open Robotics Automation Virtual Environment: An environment for testing, developing, and deploying robotics motion planning algorithms.
http://www.openrave.org
Other
687 stars 340 forks source link

Fix QtCoin SetUserText #1331

Closed cielavenir closed 8 months ago

cielavenir commented 8 months ago

https://github.com/rdiankov/openrave/pull/1328/commits/c11d17683d35495e4c1c3712019bfd68906b818d has typo, which prevents compilation when the machine has libcoin-dev

Why autotester works fine currently? Because jhbuild does not have libcoin-dev and qtcoin is not built.

/cc @jerasman @wkentaro @florisatmujin (I believe vision team should have libcoin-dev installed on their machine and they should be affected)

cielavenir commented 8 months ago

/cc @ntohge

cielavenir commented 8 months ago

clarify: This affects only local build and autotester does not have meanings.

florisatmujin commented 8 months ago

c11d176 has typo, which prevents compilation when the machine has libcoin-dev

Why autotester works fine currently? Because jhbuild does not have libcoin-dev and qtcoin is not built.

/cc @jerasman @wkentaro @florisatmujin (I believe vision team should have libcoin-dev installed on their machine and they should be affected)

Yes, we use this a lot because the visualizer works better. And I just encountered the issue as well.

Thank you for fixing, I just confirmed by building locally with the branch of this PR that it works.

yoshikikanemoto commented 8 months ago

thanks @cielavenir